Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): allow non-default service account in DirectPath #9040

Merged
merged 2 commits into from
Apr 16, 2024
Merged

feat(bigtable): allow non-default service account in DirectPath #9040

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56fe67c
feat(bigtable): allow non-default service account in DirectPath
mohanli-ml Nov 22, 2023
3dea454
Merge branch 'main' into dp-non-default-sa
bhshkh Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bigtable/bigtable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
// Attempts direct access to spanner service over gRPC to improve throughput,
// whether the attempt is allowed is totally controlled by service owner.
o = append(o, internaloption.EnableDirectPath(true))
// Allow non-default service account in DirectPath.
o = append(o, internaloption.AllowNonDefaultServiceAccount(true))
o = append(o, opts...)
connPool, err := gtransport.DialPool(ctx, o...)
if err != nil {
Expand Down
Loading