feat(bigquery/storage/managedwriter): support default value controls #8686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature introduces a new abstraction, the versionedTemplate. The intent is for this to replace the existing schema versioning mechanism with something more general and robust. Once the swap is complete, we can support default value changes and schema changes through the same templating mechanism.
product-auto-label
bot
added
size: m
In terms of public surface, this PR adds new options to control how missing values are interpreted when writing. For ManagedStream instantiation, the options are: * WithDefaultMissingValueInterpretation (blanket setting for all columns) * WithMissingValueInterpretations (per-column settings) To support updates, these are added as AppendOptions: * UpdateDefaultMissingValueInterpretation * UpdateMissingValueInterpretations Implementation-wise, this PR rips out the previous schema-specific versioner and expands the concept to a versioned AppendRowsRequest template. This more general mechanism allows us to version all settings that manifest as request fields in the AppendRowsRequest.
product-auto-label
bot
added
size: l
shollyman
changed the title
product-auto-label
bot
added
size: xl
shollyman
requested review from
chalmerlowe and
alvarowolfx
and removed request for
chalmerlowe
quartzmo
reviewed
Oct 19, 2023
product-auto-label
bot
added
size: l
alvarowolfx
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
added minor nit on missing comment and while I'm not a huge fan of the naming of the reviseXXX functions, I don't have a better alternative ( and they are all internal so 🤷 / and this can also be a matter of it not making much sense for a non native english speaking person haha )
shollyman
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
🤖 I have created a release *beep* *boop* --- ## [1.57.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.56.0...bigquery/v1.57.0) (2023-10-30) ### Features * **bigquery/biglake:** Promote to GA ([e864fbc](https://togithub.com/googleapis/google-cloud-go/commit/e864fbcbc4f0a49dfdb04850b07451074c57edc8)) * **bigquery/storage/managedwriter:** Support default value controls ([#8686](https://togithub.com/googleapis/google-cloud-go/issues/8686)) ([dfa8e22](https://togithub.com/googleapis/google-cloud-go/commit/dfa8e22edf560211ae2a2ebf1f9a23b86887c7be)) * **bigquery:** Expose Apache Arrow data through ArrowIterator ([#8506](https://togithub.com/googleapis/google-cloud-go/issues/8506)) ([c8e7692](https://togithub.com/googleapis/google-cloud-go/commit/c8e76923621b379fb7deb6dfb944011af1d980bd)), refs [#8100](https://togithub.com/googleapis/google-cloud-go/issues/8100) * **bigquery:** Introduce query preview features ([#8653](https://togithub.com/googleapis/google-cloud-go/issues/8653)) ([f29683b](https://togithub.com/googleapis/google-cloud-go/commit/f29683bcd06567e4fc2d404f53bedbea5b5f0f90)) ### Bug Fixes * **bigquery:** Handle storage read api Recv call errors ([#8666](https://togithub.com/googleapis/google-cloud-go/issues/8666)) ([c73963f](https://togithub.com/googleapis/google-cloud-go/commit/c73963f64ef667daa8a33a5a4cc2156818fc6914)) * **bigquery:** Update golang.org/x/net to v0.17.0 ([174da47](https://togithub.com/googleapis/google-cloud-go/commit/174da47254fefb12921bbfc65b7829a453af6f5d)) * **bigquery:** Update grpc-go to v1.56.3 ([343cea8](https://togithub.com/googleapis/google-cloud-go/commit/343cea8c43b1e31ae21ad50ad31d3b0b60143f8c)) * **bigquery:** Update grpc-go to v1.59.0 ([81a97b0](https://togithub.com/googleapis/google-cloud-go/commit/81a97b06cb28b25432e4ece595c55a9857e960b7)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
bhshkh
pushed a commit
that referenced
this pull request
Nov 3, 2023
…8686) * feat(bigquery/storage/managedwriter): support default value controls In terms of public surface, this PR adds new options to control how missing values are interpreted when writing. For ManagedStream instantiation, the options are: * WithDefaultMissingValueInterpretation (blanket setting for all columns) * WithMissingValueInterpretations (per-column settings) To support updates, these are added as AppendOptions: * UpdateDefaultMissingValueInterpretation * UpdateMissingValueInterpretations Implementation-wise, this PR rips out the previous schema-specific versioner and expands the concept to a versioned AppendRowsRequest template. This more general mechanism allows us to version all settings that manifest as request fields in the AppendRowsRequest.
bhshkh
pushed a commit
that referenced
this pull request
Nov 3, 2023
🤖 I have created a release *beep* *boop* --- ## [1.57.0](https://togithub.com/googleapis/google-cloud-go/compare/bigquery/v1.56.0...bigquery/v1.57.0) (2023-10-30) ### Features * **bigquery/biglake:** Promote to GA ([e864fbc](https://togithub.com/googleapis/google-cloud-go/commit/e864fbcbc4f0a49dfdb04850b07451074c57edc8)) * **bigquery/storage/managedwriter:** Support default value controls ([#8686](https://togithub.com/googleapis/google-cloud-go/issues/8686)) ([dfa8e22](https://togithub.com/googleapis/google-cloud-go/commit/dfa8e22edf560211ae2a2ebf1f9a23b86887c7be)) * **bigquery:** Expose Apache Arrow data through ArrowIterator ([#8506](https://togithub.com/googleapis/google-cloud-go/issues/8506)) ([c8e7692](https://togithub.com/googleapis/google-cloud-go/commit/c8e76923621b379fb7deb6dfb944011af1d980bd)), refs [#8100](https://togithub.com/googleapis/google-cloud-go/issues/8100) * **bigquery:** Introduce query preview features ([#8653](https://togithub.com/googleapis/google-cloud-go/issues/8653)) ([f29683b](https://togithub.com/googleapis/google-cloud-go/commit/f29683bcd06567e4fc2d404f53bedbea5b5f0f90)) ### Bug Fixes * **bigquery:** Handle storage read api Recv call errors ([#8666](https://togithub.com/googleapis/google-cloud-go/issues/8666)) ([c73963f](https://togithub.com/googleapis/google-cloud-go/commit/c73963f64ef667daa8a33a5a4cc2156818fc6914)) * **bigquery:** Update golang.org/x/net to v0.17.0 ([174da47](https://togithub.com/googleapis/google-cloud-go/commit/174da47254fefb12921bbfc65b7829a453af6f5d)) * **bigquery:** Update grpc-go to v1.56.3 ([343cea8](https://togithub.com/googleapis/google-cloud-go/commit/343cea8c43b1e31ae21ad50ad31d3b0b60143f8c)) * **bigquery:** Update grpc-go to v1.59.0 ([81a97b0](https://togithub.com/googleapis/google-cloud-go/commit/81a97b06cb28b25432e4ece595c55a9857e960b7)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new options to control how missing values are interpreted when writing.
For ManagedStream instantiation, the options are:
WithDefaultMissingValueInterpretation(blanket setting for all columns)WithMissingValueInterpretations(per-column settings)To support updates, these are added as AppendOption options:
UpdateDefaultMissingValueInterpretationUpdateMissingValueInterpretationsImplementation-wise, this PR removes the previous schema-specific
versioner (
descriptorVersion) and expands the concept to a versionedAppendRowsRequest template (
versionedTemplate). This more generalmechanism allows us to version all settings that manifest as request fields
in the AppendRowsRequest.
Fixes: #8387