Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): Run conformance tests for bigtable #8658

Merged
merged 10 commits into from
Oct 16, 2023

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Oct 9, 2023

This PR adds conformance tests to be run on presubmit and merge.
For Bigtable, testproxy is started in background and conformance tests are executed against it

@bhshkh bhshkh requested review from a team as code owners October 9, 2023 07:00
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the Bigtable API. labels Oct 9, 2023
@bhshkh bhshkh enabled auto-merge (squash) October 11, 2023 08:35
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions regarding Golang versions.

bigtable/conformance_test.sh Show resolved Hide resolved
bigtable/conformance_test.sh Show resolved Hide resolved
@triplequark
Copy link

LGTM

.github/workflows/conformance.yaml Outdated Show resolved Hide resolved
bigtable/conformance_test.sh Show resolved Hide resolved
bigtable/conformance_test.sh Outdated Show resolved Hide resolved
.github/workflows/conformance.yaml Outdated Show resolved Hide resolved
@bhshkh bhshkh requested a review from noahdietz October 16, 2023 20:25
@bhshkh bhshkh merged commit 2077158 into googleapis:main Oct 16, 2023
8 of 11 checks passed
@bhshkh bhshkh deleted the test/bigtable-conformance branch October 16, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants