-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datastore): Allow saving nested byte slice #8540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: datastore
Issues related to the Datastore API.
labels
Sep 10, 2023
enocom
reviewed
Sep 12, 2023
enocom
approved these changes
Sep 12, 2023
kolea2
reviewed
Sep 13, 2023
kolea2
reviewed
Sep 13, 2023
kolea2
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Saving nested byte slice through Datastore Go client libary throws error
flattening nested structs leads to a slice of slices
Cause: Datastore does not allow saving entities with nested lists and throws error:
rpc error: code = InvalidArgument desc = list_value cannot contain a Value containing another list_value
.To avoid this, the Datastore client library has a validation to prevent slice of slices. But it does not check the datatype of elements in the slice. This is incorrect since Datastore service allows saving nested list of bytes (In Go, byte is an alias for Uint8 ) . So, the library should allow such lists as well.
Fix: Correct the validation condition