test(datastore): Retry aggregation query testcase on failure #8487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhshkh
added
the
do not merge
product-auto-label
bot
added
size: xs
bhshkh
changed the title
bhshkh
removed
the
do not merge
enocom
reviewed
Aug 28, 2023
product-auto-label
bot
added
size: s
bhshkh
changed the title
enocom
approved these changes
Aug 28, 2023
kolea2
approved these changes
Aug 28, 2023
| @@ -874,18 +874,20 @@ func TestIntegration_AggregationQueries(t *testing.T) { | |||
| } | |||
|
|
|||
| for _, testCase := range testCases { | |||
| gotAggResult, gotErr := client.RunAggregationQuery(ctx, testCase.aggQuery) | |||
| gotFailure := gotErr != nil | |||
| testutil.Retry(t, 10, time.Second, func(r *testutil.R) { | |||
There was a problem hiding this comment.
can you add a quick comment why we're adding a retry here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Kokoro build fails with error
Cause: Entities are read too soon after creating and thus are not reflected in the aggregation results.
Fix: Add explicit sleep before running aggregation queries