Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD #8438

Merged
merged 8 commits into from
Aug 18, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Aug 17, 2023

  • Regenerate this pull request now.

PiperOrigin-RevId: 557935020

Source-Link: googleapis/googleapis@38e1f31

Source-Link: https://github.com/googleapis/googleapis-gen/commit/5bbe39d37218a420b2368c37541de5887db7d6af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWJiZTM5ZDM3MjE4YTQyMGIyMzY4YzM3NTQxZGU1ODg3ZGI3ZDZhZiJ9

… RESOURCE_EXHAUSTD

PiperOrigin-RevId: 557935020

Source-Link: googleapis/googleapis@38e1f31

Source-Link: googleapis/googleapis-gen@5bbe39d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWJiZTM5ZDM3MjE4YTQyMGIyMzY4YzM3NTQxZGU1ODg3ZGI3ZDZhZiJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 17, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot changed the title fix: Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD fix(pubsub): Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review August 18, 2023 00:04
@gcf-owl-bot gcf-owl-bot bot requested review from a team, shollyman and bhshkh as code owners August 18, 2023 00:04
@snippet-bot
Copy link

snippet-bot bot commented Aug 18, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 18, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Aug 18, 2023
@quartzmo
Copy link
Member

+ pushd policytroubleshooter
+ runPresubmitTests
+ [[ /tmpfs/src/google-cloud-go/policytroubleshooter == *\/\i\n\t\e\r\n\a\l\/* ]]
+ [[ /tmpfs/src/google-cloud-go/policytroubleshooter == *\/\t\h\i\r\d\_\p\a\r\t\y\/* ]]
+ '[' -z ']'
/tmpfs/src/google-cloud-go/policytroubleshooter /tmpfs/src/google-cloud-go
+ go test -race -v -timeout 15m -short ./...
+ tee sponge_log.log
go: downloading cloud.google.com/go/iam v1.1.0
/go/pkg/mod/cloud.google.com/go/[email protected]/apiv2/iampb/policy.pb.go:28:2: missing go.sum entry for module providing package cloud.google.com/go/longrunning/autogen/longrunningpb (imported by cloud.google.com/go/iam/apiv2/iampb); to add:
	go get cloud.google.com/go/iam/apiv2/[email protected]
+ '[' -f emulator_test.sh ']'
+ cat sponge_log.log
+ go-junit-report -set-exit-code
+ exit_code=0
+ [[ /tmpfs/src/google-cloud-go/policytroubleshooter != *\/\i\n\t\e\r\n\a\l\/* ]]
+ go build ./...
/go/pkg/mod/cloud.google.com/go/[email protected]/apiv2/iampb/policy.pb.go:28:2: missing go.sum entry for module providing package cloud.google.com/go/longrunning/autogen/longrunningpb (imported by cloud.google.com/go/iam/apiv2/iampb); to add:
	go get cloud.google.com/go/iam/apiv2/[email protected]
/tmpfs/src/google-cloud-go
+ exit_code=1

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2023
@quartzmo quartzmo added the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2023
@quartzmo
Copy link
Member

=== RUN   TestClient_CustomRetry
    pubsub_test.go:58: got: &{{100000000 60000000000 4 0} [10 1 13 8 2 14 4]}, want: &{{100000000 60000000000 1.3 0} [10 1 13 8 2 14 4]}
--- FAIL: TestClient_CustomRetry (0.03s)

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 81a33c0 into main Aug 18, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch August 18, 2023 20:00
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2023
quartzmo added a commit to quartzmo/google-cloud-go that referenced this pull request Aug 18, 2023
quartzmo added a commit that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants