Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datastore): Multi DB support #8276

Merged
merged 9 commits into from
Jul 26, 2023
Merged

feat(datastore): Multi DB support #8276

merged 9 commits into from
Jul 26, 2023

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jul 18, 2023

No description provided.

@bhshkh bhshkh requested review from a team as code owners July 18, 2023 00:55
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: datastore Issues related to the Datastore API. labels Jul 18, 2023
@bhshkh bhshkh requested a review from enocom July 18, 2023 18:05
@bhshkh bhshkh enabled auto-merge (squash) July 20, 2023 00:44
enocom
enocom reviewed Jul 20, 2023
View reviewed changes
datastore/client.go Outdated Show resolved Hide resolved
datastore/datastore.go Outdated Show resolved Hide resolved
datastore/datastore.go Outdated Show resolved Hide resolved
datastore/integration_test.go Outdated Show resolved Hide resolved
datastore/datastore_test.go Outdated Show resolved Hide resolved
@bhshkh bhshkh requested a review from enocom July 21, 2023 19:22
@bhshkh bhshkh disabled auto-merge July 24, 2023 21:57
@bhshkh bhshkh enabled auto-merge (squash) July 24, 2023 21:57
@bhshkh bhshkh requested a review from kolea2 July 24, 2023 21:58
kolea2
kolea2 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just have one question

datastore/integration_test.go Show resolved Hide resolved
kolea2
kolea2 reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry one last nit

datastore/client.go Show resolved Hide resolved
@bhshkh bhshkh self-assigned this Jul 26, 2023
noahdietz
noahdietz approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for kokoro script change.

@bhshkh bhshkh merged commit e4d07a0 into googleapis:main Jul 26, 2023
@release-please release-please bot mentioned this pull request Jul 26, 2023
Merged
@bhshkh bhshkh deleted the feature-datastore-multi-db branch July 26, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

@noahdietz noahdietz noahdietz approved these changes

@enocom enocom enocom approved these changes

Assignees

@bhshkh bhshkh

Labels
api: datastore Issues related to the Datastore API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhshkh @enocom @noahdietz @kolea2