chore(internal): update postprocessor README instructions #7708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
force-pushed
the
postprocessor-readme
branch
from
bb6d976 to
5fb0879
Compare
codyoss
reviewed
Apr 7, 2023
internal/postprocessor/README.md
Outdated
| ``` | ||
| *Note*: The docker container needs to be built with the context of the entire | ||
| `google-cloud-go/internal` directory. If building the container directly with | ||
| `docker`, rather than with Cloud Build as instructed below, be sure to do so |
There was a problem hiding this comment.
This is fine for now, but would you file an issue about making this easier. I don't think we should have to have the context of the internal directory anymore since I decoupled the postprocessor from gapicgen earlier this week.
There was a problem hiding this comment.
Can we just delete this note? I think building the container with Cloud Build is easy and simple.
There was a problem hiding this comment.
Deleted the note. Let me know if you want something added here, or if an issue needs to be filed.
codyoss
reviewed
Apr 7, 2023
codyoss
approved these changes
Apr 10, 2023
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.