refactor(storage): replace manual retries in tests #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
tritone
reviewed
Aug 16, 2022
| t.Errorf("ACL.List: object ACL list failed: %v", err) | ||
| } | ||
|
|
||
| if !containsACL(acls, aclEntity, RoleReader) { |
There was a problem hiding this comment.
Unfortunately this check needs to be retried as well, since it's possible/likely that the call will succeed but the check will fail.
It might be better to leave the original code for stuff with this pattern.
There was a problem hiding this comment.
Oh interesting... so it's possible for a situation where the metadata is updated for bucket level access policy but the acls are not yet populated?
There was a problem hiding this comment.
Actually I looked at this again and I think I was wrong, I believe that as long as ACL.List() succeeds then it should contain the correct items in this instance. Feel free to revert to what you had originally!
product-auto-label
bot
added
size: m
tritone
approved these changes
Aug 26, 2022
product-auto-label
bot
added
size: l
BrennaEpp
added a commit
to BrennaEpp/google-cloud-go
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5032
Also adds a retry to the HMAC key test that fixes #6544