Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): increase modack deadline RPC timeout #6289

Merged
merged 2 commits into from
Jun 30, 2022
Merged

fix(pubsub): increase modack deadline RPC timeout #6289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27cb5c
fix(pubsub): increase modack deadline RPC timeout
hongalex Jun 30, 2022
a875070
Merge branch 'main' into increase-modack-deadline
hongalex Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pubsub/iterator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ func (it *messageIterator) sendModAck(m map[string]bool, deadline time.Duration)
// transient (since the deadline is relative to the current time) and it
// isn't crucial for correctness (since expired messages will just be
// resent).
cctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
cctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
defer cancel()
bo := gax.Backoff{
Initial: 100 * time.Millisecond,
Expand Down