Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigquery): address minor test issues #6202

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jun 16, 2022

in the first, the integration tests running too long came into conflict
with a expiration time that was too short. Lengthened the expiration used
in the test to something more accomodating.

In the second, cleanup some usages of xerrors in testing that can be moved to
errors as we're now no longer supporting older go versions.

Fixes: #6198
Fixes: #6199

in the first, the integration tests running too long came into conflict
with a expiration time that was too short.  lengthened the test
accordingly.

In the second, cleanup some usages of xerrors that can be moved to
errors as we're now no longer supporting older go versions.
@shollyman shollyman requested review from codyoss and a team June 16, 2022 19:42
@shollyman shollyman requested a review from a team as a code owner June 16, 2022 19:42
@shollyman shollyman requested a review from prash-mi June 16, 2022 19:42
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the BigQuery API. labels Jun 16, 2022
@shollyman shollyman enabled auto-merge (squash) June 16, 2022 19:42
@shollyman shollyman removed the request for review from prash-mi June 16, 2022 19:42
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman merged commit 001d08b into googleapis:main Jun 16, 2022
@shollyman shollyman deleted the fix-tests branch June 16, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery: TestIntegration_TableUseLegacySQL failed bigquery: TestIntegration_TableUpdate failed
2 participants