Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pubsub): clarify ack/nack cannot be called from goroutine #5718

Merged
merged 1 commit into from
Mar 3, 2022
Merged

docs(pubsub): clarify ack/nack cannot be called from goroutine #5718

merged 1 commit into from
Mar 3, 2022

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Mar 3, 2022

For more information, see GoogleCloudPlatform/golang-samples#2456

@hongalex hongalex requested review from a team as code owners March 3, 2022 09:13
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the Pub/Sub API. labels Mar 3, 2022
codyoss
codyoss approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good call out, thanks for adding this to the docs!

@hongalex hongalex merged commit b433688 into googleapis:main Mar 3, 2022
@horgh horgh mentioned this pull request Jul 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongalex @codyoss