fix(pubsub): update quiescenceDur in failing e2e test #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This was referenced Mar 11, 2021
Closed
Closed
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestEndToEnd_LongProcessingTimeused to depend on a grpccancellederror to finish before the 15 second test timer expires. After #3752, we hide these cancelled errors in synchronous pull to be consistent with streaming pull.Since no fatal error was being thrown, the
Receivecall gets stuck as we stop processing after the default 60 seconds. Increase this to 120 seconds (or 12 * ackDeadline), which is the upper bound of processing times so all messages received are eventually acked and doesn't block theReceivecall. Also, decrease the number of messages published so we only have one batch received. This could have been left as-is, but we would increase the total time the test takes, and is unnecessary to what the test was trying to accomplish.Fixes #3773