chore(internal/kokoro): enable apidiff #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
noahdietz
commented
Mar 2, 2021
| @@ -34,7 +31,7 @@ go install golang.org/x/exp/cmd/apidiff | |||
| # working on an out-of-date branch, and master gets some new feature (that has | |||
| # nothing to do with your work on your branch), you'll get an error message. | |||
| # Thankfully the fix is quite simple: rebase your branch. | |||
| git clone https://code.googlesource.com/gocloud /tmp/gocloud | |||
| git clone https://github.com/googleapis/google-cloud-go /tmp/gocloud | |||
|
|
|||
| MANUALS="bigquery bigtable datastore firestore pubsub spanner storage logging" | |||
| STABLE_GAPICS="container/apiv1 dataproc/apiv1 iam iam/admin/apiv1 iam/credentials/apiv1 kms/apiv1 language/apiv1 logging/apiv2 logging/logadmin pubsub/apiv1 spanner/apiv1 translate/apiv1 vision/apiv1" | |||
There was a problem hiding this comment.
This is 1. out of date and 2. not scalable imo.
Any ideas?
|
FWIW this didn't fully work if you check the logs: https://source.cloud.google.com/results/invocations/ba4cca48-fddb-48c4-9273-91db07eb998c/targets/cloud-devrel%2Fclient-libraries%2Fgo%2Fgoogle-cloud-go%2Fpresubmit%2Fgo116/log The manuals being submodules didn't play nice with the go 1.16 go.sum requirements. Gonna need to fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apidiffgo versionto target to be 1.16.x