Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logging): Debranding of Stackdriver #2839

Merged
merged 5 commits into from
Oct 14, 2020
Merged

refactor(logging): Debranding of Stackdriver #2839

merged 5 commits into from
Oct 14, 2020

Conversation

simonz130
Copy link

@simonz130 simonz130 commented Sep 10, 2020 •
edited by freelerobot
Loading

Fixes #3007
Stackdriver Logging is now called Cloud Logging, so we are debranding across all Cloud Logging repos.

Here is the update for the readme of logging client library in Go.

Debranding of Stackdriver
962a30d 
Stackdriver Logging is now called Cloud Logging, so we are debranding across all Cloud Logging repos.
Here is the update for the readme of logging client library in Go.
@simonz130 simonz130 added the api: logging Issues related to the Cloud Logging API. label Sep 10, 2020
@simonz130 simonz130 requested review from codyoss and tbpg September 10, 2020 16:08
@simonz130 simonz130 self-assigned this Sep 10, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2020
@simonz130 simonz130 changed the title Debranding of Stackdriver chore: Debranding of Stackdriver Sep 10, 2020
@codyoss codyoss changed the title chore: Debranding of Stackdriver chore(logging): Debranding of Stackdriver Sep 10, 2020
@codyoss
Copy link
Member

codyoss commented Sep 10, 2020

It seems like there are some mentions in the manual layers docs as well, should those be updated? https://pkg.go.dev/cloud.google.com/go/logging

@freelerobot freelerobot assigned freelerobot and unassigned simonz130 Oct 13, 2020
@freelerobot freelerobot requested a review from a team as a code owner October 13, 2020 21:54
@freelerobot freelerobot changed the title chore(logging): Debranding of Stackdriver refactor(logging): Debranding of Stackdriver Oct 13, 2020
@freelerobot
Copy link
Contributor

freelerobot commented Oct 13, 2020 •
edited
Loading

It seems like there are some mentions in the manual layers docs as well, should those be updated? https://pkg.go.dev/cloud.google.com/go/logging

@codyoss I updated those as well. This PR is ready for review now.

It seems that there are no autogenerated references to "Stackdriver". But please do let me know if I am accidentally hardcoding something that should be changed upstream.

codyoss
codyoss approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 77e9aad into master Oct 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the debrandStackdriver branch October 14, 2020 14:18
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

@tbpg tbpg Awaiting requested review from tbpg

Assignees

@freelerobot freelerobot

Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logging: Debrand Cloud Logging library from Stackdriver
3 participants
@simonz130 @codyoss @freelerobot