Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: encoding text #1425

Closed
wants to merge 4 commits into from

Conversation

giautm
Copy link

@giautm giautm commented May 10, 2019

I added support for encoding.TextMarshaler & encoding.TextUnmarshaler. It helpful to convert some types like uuid.UUID from/to strings

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 10, 2019
@giautm
Copy link
Author

giautm commented May 10, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 10, 2019
@jeanbza
Copy link
Contributor

jeanbza commented May 10, 2019

Thanks! This seems very reasonable to me and worth pursuing. However, we are currently unable to accept PRs on github. (this repository is a mirror of the actual repository) Do you mind submitting for review through gerrit? See our CONTRIBUTING.md

@jeanbza jeanbza closed this May 10, 2019
@giautm
Copy link
Author

giautm commented May 10, 2019

@jadekler : I submitted changes to https://code-review.googlesource.com/c/gocloud/+/41090

@treeder
Copy link

treeder commented Mar 12, 2020

Would be nice to get this supported. Noticed the PR on Gerrit never got merged.

@treeder
Copy link

treeder commented Apr 10, 2020

Any update on this?

@treeder
Copy link

treeder commented Jun 11, 2020

This change got abandoned on Google code saying GitHub is now the source of truth so can we reopen this please? Seems like such a simple change, such an important thing to have and a PR (this one) with the change ready to go, yet it doesn't get added?

@giautm giautm mentioned this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants