-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore: encoding text #1425
Firestore: encoding text #1425
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks! This seems very reasonable to me and worth pursuing. However, we are currently unable to accept PRs on github. (this repository is a mirror of the actual repository) Do you mind submitting for review through gerrit? See our CONTRIBUTING.md |
@jadekler : I submitted changes to https://code-review.googlesource.com/c/gocloud/+/41090 |
Would be nice to get this supported. Noticed the PR on Gerrit never got merged. |
Any update on this? |
This change got abandoned on Google code saying GitHub is now the source of truth so can we reopen this please? Seems like such a simple change, such an important thing to have and a PR (this one) with the change ready to go, yet it doesn't get added? |
I added support for
encoding.TextMarshaler
&encoding.TextUnmarshaler
. It helpful to convert some types like uuid.UUID from/to strings