Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(logging): Minimized risk of flaky metrics/sinks tests by adding retries #11331

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

gkevinzheng
Copy link
Contributor

Fixes flaky logging/logadmin tests by adding retries to methods that have failed due to rpc: Unavailable error codes.

@gkevinzheng gkevinzheng requested a review from bhshkh December 20, 2024 18:12
@gkevinzheng gkevinzheng requested review from a team as code owners December 20, 2024 18:12
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Dec 20, 2024
@gkevinzheng gkevinzheng changed the title tests(logging): Minimized likelihood of metrics/sinks tests failing by adding retries tests(logging): Minimized risk of flaky metrics/sinks tests by adding retries Dec 20, 2024
@gkevinzheng gkevinzheng merged commit 946c3e8 into googleapis:main Dec 20, 2024
10 checks passed
@gkevinzheng gkevinzheng deleted the logging-logadmin-retries branch December 20, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants