chore(spanner): track precommit token for R/W multiplexed session #11229
+333
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul2393
force-pushed
the
rw_mux_support
branch
from
e3f471d to
d2fd3f3
Compare
rahul2393
force-pushed
the
rw_mux_support
branch
from
864aa10 to
db4477f
Compare
rahul2393
force-pushed
the
rw_mux_support
branch
from
69209dd to
9c3768b
Compare
rahul2393
changed the title
rahul2393
force-pushed
the
rw_mux_support
branch
5 times, most recently
from
ef5e044 to
3b75ad7
Compare
rahul2393
force-pushed
the
rw_mux_support
branch
from
3b75ad7 to
aa0292d
Compare
rahul2393
force-pushed
the
rw_mux_support
branch
from
9671c6c to
9380c32
Compare
rahul2393
force-pushed
the
rw_mux_support
branch
2 times, most recently
from
7561e70 to
9dca2e8
Compare
…r is because of multiplex from server
rahul2393
force-pushed
the
rw_mux_support
branch
from
9dca2e8 to
f7ae1bf
Compare
harshachinta
approved these changes
Dec 21, 2024
harshachinta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a read-write transaction is executed on a multiplexed session, the RPC responses of that transaction return a MultiplexedSessionPrecommitToken. In client library, the precommit token with the highest sequence number is tracked at the transaction context level. During the commit, this latest precommit token is fetched and set in the CommitRequest. If the precommit token is not set during the commit, the backend will throw an INVALID_ARGUMENT error.
Including the latest token in the CommitRequest is essential to prevent latency regression, though it does not impact the correctness of the transaction.
This PR tracks the precommit token from the following RPC responses,