Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): store credentials as auth.Credentials #11121

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(storage): store credentials as auth.Credentials #11121

wants to merge 3 commits into from
+35 −26

Conversation

BrennaEpp
Copy link
Contributor

Migrate from google.Credentials to auth.Credentials where posible

@BrennaEpp
chore(storage): store credentials as auth.Credentials
e81012e 
Migrate from google.Credentials to auth.Credentials where posible
@BrennaEpp BrennaEpp requested review from a team as code owners November 12, 2024 21:21
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 12, 2024
tritone
tritone approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you confirm that all relevant integration tests work?

@BrennaEpp BrennaEpp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees

@quartzmo quartzmo

Labels
api: storage Issues related to the Cloud Storage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennaEpp @tritone @quartzmo