Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): Add supported models in tokenizer #10939

Merged
merged 25 commits into from
Oct 1, 2024

Conversation

happy-qiao
Copy link
Contributor

No description provided.

@happy-qiao happy-qiao requested review from a team as code owners October 1, 2024 12:33
@eliben
Copy link
Contributor

eliben commented Oct 1, 2024

For future PRs, please create a fresh branch for each one.
Right now I see 25 commits in this PR, combining your other commits from older PRs, this is confusing for reviewing and I worry about accidental merging every time.

@eliben eliben added the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2024
@eliben eliben changed the title chore(vertexai): Add supported models in tokenizer feat(vertexai): Add supported models in tokenizer Oct 1, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3d9ef48 into googleapis:main Oct 1, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants