-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): handle non-Transport DefaultTransport #10733
Merged
codyoss
merged 3 commits into
googleapis:main
from
adapap:adapap/non-default-transport-newclient
Aug 23, 2024
Merged
fix(auth): handle non-Transport DefaultTransport #10733
codyoss
merged 3 commits into
googleapis:main
from
adapap:adapap/non-default-transport-newclient
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapap
force-pushed
the
adapap/non-default-transport-newclient
branch
from
August 22, 2024 01:38
ea803b5
to
7fd4e3a
Compare
@adapap Can you please create an issue for discussing the change, thanks. |
codyoss
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 22, 2024
adapap
force-pushed
the
adapap/non-default-transport-newclient
branch
from
August 22, 2024 18:27
7fd4e3a
to
be8c35f
Compare
codyoss
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 22, 2024
codyoss
reviewed
Aug 22, 2024
If a client does not specify opts.BaseRoundTripper in httptransport.NewClient, avoid a panic if the global http.DefaultTransport has been overwritten to something that is not an instance of *http.Transport.
adapap
force-pushed
the
adapap/non-default-transport-newclient
branch
from
August 22, 2024 20:51
f985ea5
to
e034124
Compare
codyoss
added
automerge
Merge the pull request once unit tests and other checks pass.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Aug 23, 2024
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 23, 2024
codyoss
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 23, 2024
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 23, 2024
codyoss
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Aug 23, 2024
codyoss
approved these changes
Aug 23, 2024
@adapap Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client does not specify opts.BaseRoundTripper in
httptransport.NewClient
, avoid a panic if the global http.DefaultTransport has been overwritten to something that is not an instance of *http.Transport.Our use case is to create a new Google API client, but the constructor for NewClient does not allow passing a
BaseRoundTripper
option as seen here.Fixes #10742.