fix(auth): use default client for universe metadata lookup #10551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this code was first introduced we did not have the context methods in the metadata package so we set the timeout on the client. Now that we do we should use context to set the timeout and use the default client the metadata package provides. Fixes: googleapis#10544
codyoss
added
the
automerge
noahdietz
approved these changes
Jul 15, 2024
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.2](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.7.1...auth/v0.7.2) (2024-07-22) ### Bug Fixes * **auth:** Use default client for universe metadata lookup ([#10551](https://togithub.com/googleapis/google-cloud-go/issues/10551)) ([d9046fd](https://togithub.com/googleapis/google-cloud-go/commit/d9046fdd1435d1ce48f374806c1def4cb5ac6cd3)), refs [#10544](https://togithub.com/googleapis/google-cloud-go/issues/10544) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
eliben
pushed a commit
to eliben/google-cloud-go
that referenced
this pull request
Jul 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.2](https://togithub.com/googleapis/google-cloud-go/compare/auth/v0.7.1...auth/v0.7.2) (2024-07-22) ### Bug Fixes * **auth:** Use default client for universe metadata lookup ([googleapis#10551](https://togithub.com/googleapis/google-cloud-go/issues/10551)) ([d9046fd](https://togithub.com/googleapis/google-cloud-go/commit/d9046fdd1435d1ce48f374806c1def4cb5ac6cd3)), refs [googleapis#10544](https://togithub.com/googleapis/google-cloud-go/issues/10544) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this code was first introduced we did not have the context methods in the metadata package so we set the timeout on the client. Now that we do we should use context to set the timeout and use the default client the metadata package provides.
Fixes: #10544