Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner): fix negative values for max_in_use_sessions metrics #10449 #10508

Merged
merged 5 commits into from
Jul 16, 2024
Merged

fix(spanner): fix negative values for max_in_use_sessions metrics #10449 #10508

merged 5 commits into from
Jul 16, 2024

Conversation

rahul2393
Copy link
Contributor

Internal bug: b/343756862

Previous work: #10449

@rahul2393 rahul2393 requested review from a team as code owners July 4, 2024 04:40
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jul 4, 2024
olavloite
olavloite reviewed Jul 4, 2024
View reviewed changes
spanner/session.go Outdated Show resolved Hide resolved
@rahul2393 rahul2393 enabled auto-merge (squash) July 15, 2024 14:52
@rahul2393 rahul2393 merged commit 4e180f4 into main Jul 16, 2024
9 checks passed
@rahul2393 rahul2393 deleted the fix_negative_metrics branch July 16, 2024 09:20
@release-please release-please bot mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@harshachinta harshachinta Awaiting requested review from harshachinta

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul2393 @olavloite