chore(internal/protoveneer): support time #10266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protos represent time using the timestamppb.Timestamp type. Support converting that to and from a time.Time.
jba
added a commit
to google/generative-ai-go
that referenced
this pull request
May 25, 2024
Add three fields to `File` that are of type time.Time. This requires the changes to protoveneer in googleapis/google-cloud-go#10266, which also includes changes to the support packages. Running `go generate` also introduced two additional `File` fields, Error and Metadata, that we will deal with later. There are also additions to the discovery client which don't concern us.
eliben
approved these changes
May 25, 2024
jba
added a commit
to google/generative-ai-go
that referenced
this pull request
May 26, 2024
Add three fields to `File` that are of type time.Time. This requires the changes to protoveneer in googleapis/google-cloud-go#10266, which also includes changes to the support packages. Running `go generate` also introduced two additional `File` fields, Error and Metadata, that we will deal with later. There are also additions to the discovery client which don't concern us.
beaubeas
pushed a commit
to beaubeas/Generative-AI-go
that referenced
this pull request
Sep 23, 2024
Add three fields to `File` that are of type time.Time. This requires the changes to protoveneer in googleapis/google-cloud-go#10266, which also includes changes to the support packages. Running `go generate` also introduced two additional `File` fields, Error and Metadata, that we will deal with later. There are also additions to the discovery client which don't concern us.
TechRanger101
added a commit
to TechRanger101/Generative-AI-GoLang
that referenced
this pull request
Nov 27, 2024
Add three fields to `File` that are of type time.Time. This requires the changes to protoveneer in googleapis/google-cloud-go#10266, which also includes changes to the support packages. Running `go generate` also introduced two additional `File` fields, Error and Metadata, that we will deal with later. There are also additions to the discovery client which don't concern us.
CascadeCrafter
added a commit
to CascadeCrafter/Generative-AI-GoLang
that referenced
this pull request
Dec 2, 2024
Add three fields to `File` that are of type time.Time. This requires the changes to protoveneer in googleapis/google-cloud-go#10266, which also includes changes to the support packages. Running `go generate` also introduced two additional `File` fields, Error and Metadata, that we will deal with later. There are also additions to the discovery client which don't concern us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protos represent time using the timestamppb.Timestamp type.
Support converting that to and from a time.Time.