-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(internal/kokoro): skip submodules repeated test if root directoy is already pushd #10265
Conversation
…ry is already pushd
I'm not sure a change to a file in the top-dir (e.g. |
./... is a module aware command and should only run in the scope of a module |
@codyoss Thanks, |
Hence the issue |
43c1296
to
6cee763
Compare
6cee763
to
95a0916
Compare
In #10251 there are repeated tests which internal/kokoro/presubmit.sh bash script was running.
Example:
will run test twice for spanner once with "pushd ./spanner" and other with "pushd spanner"
We don't really need to run the sub-directories test if changes were detected in root directory(".") since it will anyways run all the tests in submodules.