Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(civil): add Compare method to Date, Time, and DateTime #10010

Merged
merged 2 commits into from
Apr 22, 2024
Merged

feat(civil): add Compare method to Date, Time, and DateTime #10010

merged 2 commits into from
Apr 22, 2024

Conversation

shota3506
Copy link
Contributor

implementation for #10009

@shota3506 shota3506 requested a review from a team as a code owner April 20, 2024 02:38
noahdietz
noahdietz approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this seems great to have.

@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@noahdietz noahdietz added automerge Merge the pull request once unit tests and other checks pass. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit and removed automerge Merge the pull request once unit tests and other checks pass. labels Apr 22, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 34455c1 into googleapis:main Apr 22, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Apr 22, 2024
@release-please release-please bot mentioned this pull request Apr 22, 2024
Merged
noahdietz added a commit that referenced this pull request Apr 22, 2024
@noahdietz
Revert "feat(civil): add Compare method to Date, Time, and DateTime (#…
f566b59 
…10010)"

This reverts commit 34455c1.
@noahdietz noahdietz mentioned this pull request Apr 22, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 22, 2024
@noahdietz
chore: revert "feat(civil): add Compare method to Date, Time, and Dat…
50994e7 
…eTime" (#10020)

Reverts #10010

`time` `Compare` was added in Go 1.20 and we still need to support Go 1.19. Temporarily reverting this.
gcf-merge-on-green bot pushed a commit that referenced this pull request May 8, 2024
@release-please
chore(main): release 0.113.0 (#9775)
7f2cefe 
🤖 I have created a release *beep* *boop*
---


## [0.113.0](https://togithub.com/googleapis/google-cloud-go/compare/v0.112.2...v0.113.0) (2024-05-08)


### Features

* **civil:** Add Compare method to Date, Time, and DateTime ([#10010](https://togithub.com/googleapis/google-cloud-go/issues/10010)) ([34455c1](https://togithub.com/googleapis/google-cloud-go/commit/34455c15d62b089f3281ff4c663245e72b257f37))


### Bug Fixes

* **all:** Bump x/net to v0.24.0 ([#10000](https://togithub.com/googleapis/google-cloud-go/issues/10000)) ([ba31ed5](https://togithub.com/googleapis/google-cloud-go/commit/ba31ed5fda2c9664f2e1cf972469295e63deb5b4))
* **debugger:** Add internaloption.WithDefaultEndpointTemplate ([3b41408](https://togithub.com/googleapis/google-cloud-go/commit/3b414084450a5764a0248756e95e13383a645f90))
* **internal/aliasfix:** Handle import paths correctly ([#10097](https://togithub.com/googleapis/google-cloud-go/issues/10097)) ([fafaf0d](https://togithub.com/googleapis/google-cloud-go/commit/fafaf0d0a293096559a4655ea61062cb896f1568))
* **rpcreplay:** Properly unmarshal dynamic message ([#9774](https://togithub.com/googleapis/google-cloud-go/issues/9774)) ([53ccb20](https://togithub.com/googleapis/google-cloud-go/commit/53ccb20d925ccb00f861958d9658b55738097dc6)), refs [#9773](https://togithub.com/googleapis/google-cloud-go/issues/9773)


### Documentation

* **testing:** Switch deprecated WithInsecure to WithTransportCredentials ([#10091](https://togithub.com/googleapis/google-cloud-go/issues/10091)) ([2b576ab](https://togithub.com/googleapis/google-cloud-go/commit/2b576abd1c3bfca2f962de0e024524f72d3652c0))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@shota3506 shota3506 mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shota3506 @noahdietz @kokoro-team