-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: support gRPC dial timeout #946
Comments
@zombiezen Could we use a detachable context for this? Is one available? |
You don't really want this. gRPC client conns shouldn't block on healthy, they should block on first RPC. That subsequent RPC should have a deadline set, which is the thing you would care about. |
Thanks @zombiezen! It makes sense when you consider the possibility of lazy connections. And maybe this too could be added one day to the documentation. 🙂 |
Agreed. We will improve our docs on how to use context. |
Remove the gRPC binding for generated compute protos as they are not valid. This reduces the LoC in this package by ~13%. Source-Link: googleapis/googleapis@80bfb11 Source-Link: googleapis/googleapis-gen@1096119 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTA5NjExOTczYWVlN2Y0MDFkYzdkNzExNWUwZDYwYjU0ZDdkYmNkMSJ9
#11024) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 689439500 Source-Link: https://togithub.com/googleapis/googleapis/commit/9e7a2e530599ebb1d0ed0ffb298b716585a366fe Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/069e663b58bb092e6447d2073373bc56517abc4c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDY5ZTY2M2I1OGJiMDkyZTY0NDdkMjA3MzM3M2JjNTY1MTdhYmM0YyJ9 BEGIN_NESTED_COMMIT feat(spanner/admin/instance): Add support for Cloud Spanner Default Backup Schedules PiperOrigin-RevId: 688946300 Source-Link: https://togithub.com/googleapis/googleapis/commit/b11e6b0741fc333f7d558447f2efda76db44243d Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/f93f56b21ff01e499977c4dd54689cce1b7cf530 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjkzZjU2YjIxZmYwMWU0OTk5NzdjNGRkNTQ2ODljY2UxYjdjZjUzMCJ9 END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat(shopping/css): A new field `headline_offer_installment` is added to message `.google.shopping.css.v1.Attributes` feat(shopping/css): A new field `headline_offer_subscription_cost` is added to message `.google.shopping.css.v1.Attributes` feat(shopping/css): A new message `HeadlineOfferSubscriptionCost` is added feat(shopping/css): A new message `HeadlineOfferInstallment` is added feat(shopping/css): A new enum `SubscriptionPeriod` is added PiperOrigin-RevId: 688649184 Source-Link: https://togithub.com/googleapis/googleapis/commit/c8a726182c087afc514aa51a980b937d07f86540 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/3dcef19e307b679a3f6c881d79f064e885fd52fd Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2RjZWYxOWUzMDdiNjc5YTNmNmM4ODFkNzlmMDY0ZTg4NWZkNTJmZCJ9 END_NESTED_COMMIT BEGIN_NESTED_COMMIT fix(compute): reduce size of Go compute package (#946) Remove the gRPC binding for generated compute protos as they are not valid. This reduces the LoC in this package by ~13%. Source-Link: https://togithub.com/googleapis/googleapis/commit/80bfb115ac768be8fc3982123ab9fe11c3c5439e Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/109611973aee7f401dc7d7115e0d60b54d7dbcd1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTA5NjExOTczYWVlN2Y0MDFkYzdkNzExNWUwZDYwYjU0ZDdkYmNkMSJ9 END_NESTED_COMMIT
It should be possible to express a timeout on connection dial by writing
The problem is that the same context passed to
NewClient
is used in constructing aTokenSource
, which will repeatedly try to renew creds forever. We'd like to ignore deadlines and cancelation on that TokenSource context.The text was updated successfully, but these errors were encountered: