Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: remove OLM Age condition reflection #6240

Closed
frankyn opened this issue Jun 22, 2022 · 1 comment
Closed

storage: remove OLM Age condition reflection #6240

frankyn opened this issue Jun 22, 2022 · 1 comment
Assignees
@frankyn
Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.

Comments

@frankyn
Copy link
Member

frankyn commented Jun 22, 2022

Once the autogen breaking change is made to make Age in OLM conditions from int64 to *int64 we should revert changes made in #6230
@frankyn frankyn added api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like. labels Jun 22, 2022
@frankyn frankyn self-assigned this Jun 22, 2022
@frankyn frankyn mentioned this issue Aug 24, 2022
Merged
tritone pushed a commit that referenced this issue Aug 26, 2022
@frankyn
fix(storage): allow to use age=0 in OLM conditions (#6204)
c85704f 
Storage Go doesn't allow setting AgeInDays=0 after discussing with @tritone. This PR is the agreed upon path to support Age=0 in OLM conditions. It also notes that other int fields in OLM Conditions do not support 0 values.

Fixes: #6539, #6240
@tritone
Copy link
Contributor

tritone commented Aug 29, 2022

Resolved in #6204

@tritone tritone closed this as completed Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankyn frankyn

Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankyn @tritone