PubSub client is missing ABORTED from the list of retryable errors

[gracenoah]

The PubSub go client seems to have gotten out of sync in terms of the list of retryable errors, comparing with the Java client. It is missing "ABORTED".

Client

PubSub

Describe Your Environment

Ubuntu Docker on GKE

Expected Behavior

Retryable error is retried

Actual Behavior

Process dies

[gracenoah]

diff --git pubsub/service.go pubsub/service.go
index 63d4aa4e..edf8df1a 100644
--- pubsub/service.go
+++ pubsub/service.go
@@ -68,7 +68,7 @@ func isRetryable(err error) bool {
                return true
        }
        switch s.Code() {
-       case codes.DeadlineExceeded, codes.Internal, codes.ResourceExhausted:
+       case codes.OK, codes.Canceled, codes.Unknown, codes.DeadlineExceeded, codes.Internal, codes.ResourceExhausted, codes.Aborted, codes.Unavailable, codes.DataLoss:
                return true
        case codes.Unavailable:
                return !strings.Contains(s.Message(), "Server shutdownNow invoked")

This would be the necessary change it seems. I'm not in a position to contribute at this moment.

[jeanbza]

@pongad @jba Do either of you guys happen to know whether this is an omission by design, or if it's unintentional? I might be forgetting something..

[pongad]

I can't remember the events but googleapis/google-cloud-java#2461 suggests pubsub team is OK with it :)

[jeanbza]

Pub/Sub now retries aborted.

[jeanbza]

Relevant commits:

• https://code-review.googlesource.com/c/gocloud/+/36110
• cbb15e6