Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: fix TestClient_CallOptions test #10069

Closed
noahdietz opened this issue Apr 30, 2024 · 1 comment
Closed

spanner: fix TestClient_CallOptions test #10069

noahdietz opened this issue Apr 30, 2024 · 1 comment
Assignees
@harshachinta
Labels
api: spanner Issues related to the Spanner API. release blocking Required feature/issue must be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@noahdietz
Copy link
Contributor

We have to skip TestClient_CallOptions temporarily in order to merge regeneration PR #9777. It includes a Spanner retry config change which breaks some test assumptions. Fixing it in the same PR is time consuming and blocks many other changes from landing.

This should be fixed before the next spanner release.
@noahdietz noahdietz added the type: cleanup An internal cleanup or hygiene concern. label Apr 30, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Apr 30, 2024
@noahdietz noahdietz mentioned this issue Apr 30, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 30, 2024
@noahdietz
chore(spanner): temporarily skip spanner tests (#10071)
bb47185 
Updates #10070
Updates #10069
@noahdietz noahdietz added the release blocking Required feature/issue must be fixed prior to next release. label Apr 30, 2024
@noahdietz noahdietz mentioned this issue Apr 30, 2024
Merged
@noahdietz noahdietz assigned harshachinta and unassigned rahul2393 May 1, 2024
@rahul2393 rahul2393 mentioned this issue May 6, 2024
Merged
@harshachinta
Copy link
Contributor

Fixed in #10117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the Spanner API. release blocking Required feature/issue must be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noahdietz @rahul2393 @harshachinta