fix(spanner): early unlock of session pool lock during dumping the tr…

…acked session handles to avoid deadlock (#5777) * fix(spanner): early unlock of session pool lock during dumping the tracked session handles to avoid deadlock * fix dirty read issue * incorporate requested changes Co-authored-by: Rahul Yadav <[email protected]>
googleapis · Mar 23, 2022 · b007836 · b007836
1 parent dfda4d1
commit b007836
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/spanner/session.go b/spanner/session.go
@@ -72,12 +72,13 @@ func (sh *sessionHandle) recycle() {
 	}
 	p := sh.session.pool
 	tracked := sh.trackedSessionHandle
-	sh.session.recycle()
+	s := sh.session
 	sh.session = nil
 	sh.trackedSessionHandle = nil
 	sh.checkoutTime = time.Time{}
 	sh.stack = nil
 	sh.mu.Unlock()
+	s.recycle()
 	if tracked != nil {
 		p.mu.Lock()
 		p.trackedSessionHandles.Remove(tracked)