Skip to content

Commit

Permalink
test(storage): skip bucket update tests for gRPC (#7476)
Browse files Browse the repository at this point in the history
Skipping these for now due to an API behavior change. Will unskip when b/270215524 is resolved.
  • Loading branch information
tritone authored Feb 22, 2023
1 parent 1191136 commit 0559e87
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions storage/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ func TestIntegration_BucketCreateDelete(t *testing.T) {
}

func TestIntegration_BucketLifecycle(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -617,7 +617,7 @@ func TestIntegration_BucketUpdate(t *testing.T) {
}

func TestIntegration_BucketPolicyOnly(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -707,7 +707,7 @@ func TestIntegration_BucketPolicyOnly(t *testing.T) {
}

func TestIntegration_UniformBucketLevelAccess(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}
bkt := client.Bucket(prefix + uidSpace.New())
Expand Down Expand Up @@ -790,7 +790,7 @@ func TestIntegration_UniformBucketLevelAccess(t *testing.T) {
}

func TestIntegration_PublicAccessPrevention(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -884,7 +884,7 @@ func TestIntegration_PublicAccessPrevention(t *testing.T) {
}

func TestIntegration_Autoclass(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -2157,7 +2157,7 @@ func TestIntegration_SignedURL_EmptyStringObjectName(t *testing.T) {
}

func TestIntegration_BucketACL(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -3358,7 +3358,7 @@ func TestIntegration_CancelWrite(t *testing.T) {
}

func TestIntegration_UpdateCORS(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
initialSettings := []CORS{
{
Expand Down Expand Up @@ -3429,7 +3429,7 @@ func TestIntegration_UpdateCORS(t *testing.T) {
}

func TestIntegration_UpdateDefaultEventBasedHold(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -3523,7 +3523,7 @@ func TestIntegration_UpdateTemporaryHold(t *testing.T) {
}

func TestIntegration_UpdateRetentionExpirationTime(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -3607,7 +3607,7 @@ func TestIntegration_CustomTime(t *testing.T) {
}

func TestIntegration_UpdateRetentionPolicy(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
initial := &RetentionPolicy{RetentionPeriod: time.Minute}

Expand Down Expand Up @@ -3664,7 +3664,7 @@ func TestIntegration_UpdateRetentionPolicy(t *testing.T) {
}

func TestIntegration_DeleteObjectInBucketWithRetentionPolicy(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -3698,7 +3698,7 @@ func TestIntegration_DeleteObjectInBucketWithRetentionPolicy(t *testing.T) {
}

func TestIntegration_LockBucket(t *testing.T) {
ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down Expand Up @@ -3742,7 +3742,7 @@ func TestIntegration_LockBucket_MetagenerationRequired(t *testing.T) {
}

func TestIntegration_KMS(t *testing.T) {
multiTransportTest(context.Background(), t, func(t *testing.T, ctx context.Context, bucket, prefix string, client *Client) {
multiTransportTest(skipGRPC("b/270215524"), t, func(t *testing.T, ctx context.Context, bucket, prefix string, client *Client) {
h := testHelper{t}

keyRingName := os.Getenv("GCLOUD_TESTS_GOLANG_KEYRING")
Expand Down Expand Up @@ -3835,7 +3835,7 @@ func TestIntegration_PredefinedACLs(t *testing.T) {
userOwner := prefixRoleACL{prefix: "user", role: RoleOwner}
authenticatedRead := entityRoleACL{entity: AllAuthenticatedUsers, role: RoleReader}

ctx := skipJSONReads(context.Background(), "no reads in test")
ctx := skipJSONReads(skipGRPC("b/270215524"), "no reads in test")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, _ string, prefix string, client *Client) {
h := testHelper{t}

Expand Down

0 comments on commit 0559e87

Please sign in to comment.