Dispose of ASP.NET Core bits

apis/Google.Cloud.Diagnostics.AspNet/Google.Cloud.Diagnostics.AspNet/ErrorReporting/ErrorReportingExceptionFilter.cs

@@ -49,7 +49,7 @@ namespace Google.Cloud.Diagnostics.AspNet
     /// https://msdn.microsoft.com/en-us/library/system.web.mvc.iexceptionfilter.onexception(v=vs.118).aspx
     /// Docs: https://cloud.google.com/error-reporting/docs/
     /// </remarks>
-    public class ErrorReportingExceptionFilter : IExceptionFilter
+    public class ErrorReportingExceptionFilter : IExceptionFilter, IDisposable
     {
         // The service context in which this error has occurred.
         // See: https://cloud.google.com/error-reporting/reference/rest/v1beta1/projects.events#ServiceContext
@@ -97,6 +97,9 @@ public void OnException(ExceptionContext context)
             _consumer.Receive(new[] { errorEvent });
         }
 
+        /// <inheritdoc />
+        public void Dispose() => _consumer.Dispose();
+
         /// <summary>
         /// Gets information about the HTTP request and response when the exception occured 
         /// and populates a <see cref="HttpRequestContext"/> object.

apis/Google.Cloud.Diagnostics.AspNet/Google.Cloud.Diagnostics.AspNet/ErrorReporting/ErrorReportingExceptionLogger.cs

@@ -48,7 +48,7 @@ namespace Google.Cloud.Diagnostics.AspNet
     /// Reports unhandled exceptions to Google Cloud Error Reporting.
     /// Docs: https://cloud.google.com/error-reporting/docs/
     /// </remarks>
-    public sealed class ErrorReportingExceptionLogger : ExceptionLogger
+    public sealed class ErrorReportingExceptionLogger : ExceptionLogger, IDisposable
     {
         // The service context in which this error has occurred.
         // See: https://cloud.google.com/error-reporting/reference/rest/v1beta1/projects.events#ServiceContext
@@ -107,6 +107,9 @@ public override bool ShouldLog(ExceptionLoggerContext context)
             return context?.Exception != null;
         }
 
+        /// <inheritdoc />
+        public void Dispose() => _consumer.Dispose();
+
         /// <summary>
         /// Gets information about the HTTP request and response when the exception occured 
         /// and populates a <see cref="HttpRequestContext"/> object.

apis/Google.Cloud.Diagnostics.AspNet/Google.Cloud.Diagnostics.AspNet/Trace/CloudTrace.cs

@@ -72,10 +72,12 @@ namespace Google.Cloud.Diagnostics.AspNet
     /// 
     /// Docs: https://cloud.google.com/trace/docs/
     /// </remarks>
-    public sealed class CloudTrace
+    public sealed class CloudTrace : IDisposable
     {
         private readonly IManagedTracerFactory _tracerFactory;
 
+        private readonly IConsumer<TraceProto> _consumer;
+
         /// <summary>Gets the current <see cref="IManagedTracer"/> for the given request.</summary>
         public static IManagedTracer CurrentTracer =>
             TracerManager.GetCurrentTracer() ?? DoNothingTracer.Instance;
@@ -88,10 +90,10 @@ private CloudTrace(string projectId, TraceConfiguration config = null, Task<Trac
             client = client ?? TraceServiceClient.CreateAsync();
             config = config ?? TraceConfiguration.Create();
 
-            var consumer = ConsumerFactory<TraceProto>.GetConsumer(
+            _consumer = ConsumerFactory<TraceProto>.GetConsumer(
                 new GrpcTraceConsumer(client), MessageSizer<TraceProto>.GetSize, config.BufferOptions);
 
-            _tracerFactory = new ManagedTracerFactory(projectId, consumer,
+            _tracerFactory = new ManagedTracerFactory(projectId, _consumer,
                 RateLimitingTraceOptionsFactory.Create(config), TraceIdFactory.Create());
         }
 
@@ -110,8 +112,12 @@ public static void Initialize(string projectId, HttpApplication application, Tra
             // Add event handlers to the application.
             application.BeginRequest += trace.BeginRequest;
             application.EndRequest += trace.EndRequest;
+            application.Disposed += (object sender, EventArgs e) => { trace.Dispose(); };
         }
 
+        /// <inheritdoc />
+        public void Dispose() => _consumer.Dispose();
+
         private void BeginRequest(object sender, EventArgs e)
         {
             var headerContext = TraceHeaderContextUtils.CreateContext(HttpContext.Current.Request);