[Log4Net]: Adds snippet showing how to set Log4Net properties as Google Cloud log entry labels. #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
jskeet
approved these changes
Nov 19, 2020
| // Resource: log4net-custom-labels-template.xml log4net_custom_labels_template | ||
| // Sample: Custom_Labels | ||
| // Configure log4net to use Google Cloud Logging from the XML configuration file. | ||
| XmlConfigurator.Configure(LogManager.GetRepository(GetType().GetTypeInfo().Assembly), new FileInfo("log4net.xml")); |
There was a problem hiding this comment.
I suspect GetTypeInfo() can be removed everywhere now - we only didn't have it in netstandard1.*
There was a problem hiding this comment.
Ah yes, will remove from all snippets.
| // Set a property using one of the GlobaContext, ThreadContext or LogicalThreadContext classes. | ||
| LogicalThreadContext.Properties["property_for_label"] = "my label value"; | ||
| // Log some information. This log entry will be sent to Google Cloud Logging with a label | ||
| // {"label_from_property", "my label value"} |
There was a problem hiding this comment.
Possibly explain that the mapping from "property_for_label" to "label_from_property" is part of the configuration? I thought this was a typo at first.
…oud log entry labels. Towards googleapis#5325
amanda-tarafa
force-pushed
the
log4net-labels
branch
from
f1a4bab to
ab03a58
Compare
amanda-tarafa
commented
Nov 19, 2020
| // Resource: log4net-custom-labels-template.xml log4net_custom_labels_template | ||
| // Sample: Custom_Labels | ||
| // Configure log4net to use Google Cloud Logging from the XML configuration file. | ||
| XmlConfigurator.Configure(LogManager.GetRepository(GetType().GetTypeInfo().Assembly), new FileInfo("log4net.xml")); |
There was a problem hiding this comment.
Ah yes, will remove from all snippets.
| // Set a property using one of the GlobaContext, ThreadContext or LogicalThreadContext classes. | ||
| LogicalThreadContext.Properties["property_for_label"] = "my label value"; | ||
| // Log some information. This log entry will be sent to Google Cloud Logging with a label | ||
| // {"label_from_property", "my label value"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5325