Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Google.Cloud.Diagnostics packages version 4.2.0-beta01 #5379

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Release Google.Cloud.Diagnostics packages version 4.2.0-beta01 #5379

merged 1 commit into from
Sep 29, 2020

Conversation

amanda-tarafa
Copy link
Contributor

Changes in this release:

Packages in this release:

  • Release Google.Cloud.Diagnostics.Common version 4.2.0-beta01
  • Release Google.Cloud.Diagnostics.AspNetCore version 4.2.0-beta01

@amanda-tarafa
Release Google.Cloud.Diagnostics packages version 4.2.0-beta01
08faf4d 
Changes in this release:
- [Commit 5710321](googleapis@5710321): feat: Adds GoogleTraceProvider to be used by Logging when Tracing is not configured. Closes [issue 5359](googleapis#5359).
- [Commit f46b1c6](googleapis@f46b1c6): fix: Corrects Span ID format for adding to Log Entries. Fixes [issue 5358](googleapis#5358).
- [Commit 924c503](googleapis@924c503): docs: Adds documentation about environments that limit background activities. Closes [issue 5275](googleapis#5275).
- [Commit 7480149](googleapis@7480149): fix: Sets LogEntry.TraceSampled to true if tracing information is adding to the entry. Fixes [issue 5307](googleapis#5307).

Packages in this release:

- Release Google.Cloud.Diagnostics.Common version 4.2.0-beta01
- Release Google.Cloud.Diagnostics.AspNetCore version 4.2.0-beta01
@amanda-tarafa amanda-tarafa requested a review from a team as a code owner September 29, 2020 15:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2020
@amanda-tarafa amanda-tarafa merged commit a19913a into googleapis:master Sep 29, 2020
@amanda-tarafa amanda-tarafa deleted the release-pr-20200929T1506Z branch September 29, 2020 15:18
@yoshi-automation
Copy link
Contributor

  • Created release for Google.Cloud.Diagnostics.Common-4.2.0-beta01
  • Created release for Google.Cloud.Diagnostics.AspNetCore-4.2.0-beta01

@release-tool-publish-reporter
Copy link

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter
Copy link

The release build failed! Please investigate!

@amanda-tarafa
Copy link
Contributor Author

On it

@amanda-tarafa
Copy link
Contributor Author

I've triggered it again.

@EatonZ
Copy link
Contributor

EatonZ commented Sep 29, 2020

@amanda-tarafa I have downloaded this beta release and all of the changes appear to be working exactly as expected.👍

@EatonZ
Copy link
Contributor

EatonZ commented Sep 29, 2020

@amanda-tarafa Although, if the load balancer decides not to trace (does not send ;o=1 to my service), the log entry is missing trace, spanId, and traceSampled.

I'm not sure if that is correct, because now the log entry will have no association with the span/trace. Shouldn't trace and spanId still be set, but not traceSampled in these cases?

@amanda-tarafa
Copy link
Contributor Author

@EatonZ can you please create an issue with your question. We try to keep issues as independent as possible, and to not use PRs to comment except on the code content of the PR itself. It's just a matter of tidyness and making it easier for other developers to find issues.

@EatonZ
Copy link
Contributor

EatonZ commented Sep 30, 2020

@amanda-tarafa #5384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
4 participants
@amanda-tarafa @yoshi-automation @EatonZ @jskeet