Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to our NuGet packages #4889

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Apr 21, 2020

Fixes #4888.

(Once this is in, I may well do a new release of something just to check that it really, really works...)

jskeet added 3 commits April 21, 2020 09:41
Note that this moves from the old SourceLink.Create.CommandLine package to Microsoft.SourceLink.GitHub as well.

We might want to move other things to Directory.Build.targets - we can simplify the project files quite a lot, I suspect.
But this is all that's required to get SourceLink working.
Note that the CI=true is no longer necessary for SourceLink.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit 2f95ae9 into googleapis:master Apr 21, 2020
@jskeet jskeet deleted the sourcelink branch April 21, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check our package building procedure
3 participants