Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create option to allow Origin header for upload initiation #2756

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Dec 5, 2018

Fixes #2755.

(I'm going to try to get this fix verified more thoroughly before we merge.)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2018
Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, althouth I'm not familiar with this either.

@jskeet jskeet merged commit 9d4041a into googleapis:master Dec 6, 2018
@jskeet jskeet deleted the cors branch December 6, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to specify CORS on resumable upload initiate session
3 participants