Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly Dispose of the ErrorReportingExceptionFilter #803

Closed
iantalarico opened this issue Feb 24, 2017 · 3 comments
Closed

Properly Dispose of the ErrorReportingExceptionFilter #803

iantalarico opened this issue Feb 24, 2017 · 3 comments
Assignees
@iantalarico
Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@iantalarico
Copy link
Contributor

We currently do not properly clean up the ErrorReportingExceptionFilter's Resources
@iantalarico iantalarico added the api: clouderrorreporting Issues related to the Error Reporting API. label Feb 24, 2017
@iantalarico iantalarico self-assigned this Feb 24, 2017
@iantalarico iantalarico mentioned this issue Feb 24, 2017
Merged
@jskeet jskeet added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 21, 2017
@iantalarico iantalarico added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 7, 2017
@iantalarico
Copy link
Contributor Author

Dropping to P2 as the resources are alive as long as the application

@jskeet
Copy link
Collaborator

jskeet commented Dec 6, 2017

Closing for now having added this to the backlog

@jskeet jskeet closed this as completed Dec 6, 2017
@amanda-tarafa
Copy link
Contributor

amanda-tarafa commented Nov 19, 2020 •
edited
Loading

ErrorReportingExceptionFilter is from the Diagnostics.AspNet package which we don't support (except for critical bug fixes) as per #4828.
Removing this issue from backlog.

amanda-tarafa added a commit to amanda-tarafa/google-cloud-dotnet that referenced this issue Nov 19, 2020
@amanda-tarafa
chore: Backlog update.
1770a30 
 - Removes googleapis#110, googleapis#803 and googleapis#1038
 - Adds googleapis#5325
@amanda-tarafa amanda-tarafa mentioned this issue Nov 19, 2020
Merged
amanda-tarafa added a commit to amanda-tarafa/google-cloud-dotnet that referenced this issue Nov 19, 2020
@amanda-tarafa
chore: Backlog update.
674a9dd 
 - Removes googleapis#110, googleapis#803, googleapis#1038 and googleapis#1451
 - Adds googleapis#5325
amanda-tarafa added a commit that referenced this issue Nov 19, 2020
@amanda-tarafa
chore: Backlog update.
619de03 
 - Removes #110, #803, #1038 and #1451
 - Adds #5325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iantalarico iantalarico

Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jskeet @iantalarico @amanda-tarafa