-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(storage): document per-operation options #9247
doc(storage): document per-operation options #9247
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9247 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 1457 1458 +1
Lines 131845 131934 +89
=======================================
+ Hits 124690 124779 +89
Misses 7155 7155
Continue to review full report at Codecov.
|
* parameters can be specified in any order. Specifying a request option that is | ||
* not applicable to a member function results in a compile-time error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? If so, I'm not sure it is a feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can have a discussion about whether we should change this, but this is not new behavior. Note that this is referring to the static options, so something like this would fail to compile:
client.GetBucketMetadata("my-bucket",
gcs::Generation(7) // compile-time error, buckets do not have generations
);
while this would compile (and this is new behavior):
client.GetBucketMetadata("my-bucket",
g::Options{}.set<pubsub::RetryPolicyOption(...) // ignored
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's cool. I was only thinking about the behavior for Options
.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Fixes #7691
This change is