impl(storage): internal::RawClient gains options()
#9192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support per-operation options we need to get the `google::cloud::Options` of a `RawClient`. This is analogous to the `options()` accessor in the `*Connection` classes for other libraries.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9192 +/- ##
==========================================
- Coverage 94.55% 94.54% -0.01%
==========================================
Files 1449 1449
Lines 129689 129696 +7
==========================================
- Hits 122621 122620 -1
- Misses 7068 7076 +8
Continue to review full report at Codecov.
|
devbww
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support per-operation options we need to get the
google::cloud::Optionsof aRawClient. This is analogous to theoptions()accessor in the*Connectionclasses for other libraries.Part of the work for #7691
This change is