fix(common): workaround GCC "ambiguous" overload errors #9144
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9144 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 1435 1435
Lines 128262 128267 +5
=======================================
+ Hits 121004 121011 +7
+ Misses 7258 7256 -2
Continue to review full report at Codecov.
|
We used to write code like this:
```cc
template <typename U>
static auto constexpr E(U& u) {
return std::move(*u.mutable_next_page_token());
}
template <typename U>
static auto constexpr E(U& u) {
return std::move(u.next_page_token);
}
```
The idea is that only one of these overloads would be available because
of SFINAE. Some versions of GCC complain that this is ambiguous.
coryan
force-pushed
the
fix-common-workaround-mingw-w64-GCC-errors
branch
from
5970fbe to
33ee087
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
We used to write code like this:
The idea is that only one of these overloads would be available because
of SFINAE. Some versions of GCC complain that this is ambiguous.
Fixes #9111
This change is