fix(bigtable): remove unnecessary sleeps from BulkApply #9091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
approved these changes
May 27, 2022
| @@ -171,6 +172,7 @@ std::vector<FailedMutation> Table::BulkApply(BulkMutation mut) { | |||
| if (!status.ok() && !retry_policy->OnFailure(status)) { | |||
There was a problem hiding this comment.
My proposal was:
while (mutator.HasPendingMutations()) {
....
status = mutator.MakeOneRequest(*client_, client_context);
if (status.ok()) continue;
if (!retry_policy->OnFailure(status)) break;
...
}I think your approach saves the initial HasPendingMutations() probably worth it.
devbww
reviewed
May 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #9091 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 1430 1430
Lines 127076 127112 +36
=======================================
+ Hits 120020 120054 +34
- Misses 7056 7058 +2
Continue to review full report at Codecov.
|
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9089 ... although this should be tested properly.
We now check the loop condition before sleeping instead of after.
This change is