fix(storage): all HmacKey requests accept UserProject
#8928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Fix all `HmacKey` requests to accept `UserProject`. Used the opportunity to document the "common options", since I had to do that for these requests anyway. And then fixed some rendering problems.
coryan
force-pushed
the
fix-storage-missing-options-for-HmacKey-requests
branch
from
84ed8fb to
01f15b9
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8928 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 1479 1479
Lines 125259 125259
=======================================
+ Hits 116805 116807 +2
+ Misses 8454 8452 -2
Continue to review full report at Codecov.
|
scotthart
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all
HmacKeyrequests to acceptUserProject. Used the opportunityto document the "common options", since I had to do that for these
requests anyway. And then fixed some rendering problems.
Motivated by #4208
This change is