Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(bigtable): compiler warnings for ClientOptions #8914

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented May 7, 2022

Part of the work for #7230


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 7, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f53c866f24306ffb767bcc59ffd80672806c68e5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #8914 (f53c866) into main (baa88cf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8914      +/-   ##
==========================================
- Coverage   93.24%   93.24%   -0.01%     
==========================================
  Files        1477     1477              
  Lines      125053   125055       +2     
==========================================
+ Hits       116610   116611       +1     
- Misses       8443     8444       +1     
Impacted Files Coverage Δ
google/cloud/bigtable/client_options.h 100.00% <ø> (ø)
google/cloud/bigtable/client_options_test.cc 99.74% <ø> (ø)
google/cloud/bigtable/data_client.h 100.00% <ø> (ø)
google/cloud/bigtable/instance_admin_client.h 100.00% <ø> (ø)
...oogle/cloud/bigtable/instance_admin_client_test.cc 100.00% <ø> (ø)
google/cloud/bigtable/client_options.cc 100.00% <100.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 97.75% <0.00%> (-0.50%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa88cf...f53c866. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review May 7, 2022 17:10
@dbolduc dbolduc requested a review from a team as a code owner May 7, 2022 17:10
@dbolduc dbolduc merged commit 8ad25ba into googleapis:main May 7, 2022
@dbolduc dbolduc deleted the bigtable-client-options-compiler-warnings branch May 7, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants