-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(bigtable): deprecate RowReader public ctors #8887
doc(bigtable): deprecate RowReader public ctors #8887
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8887 +/- ##
==========================================
- Coverage 93.16% 93.16% -0.01%
==========================================
Files 1477 1477
Lines 124810 124836 +26
==========================================
+ Hits 116283 116302 +19
- Misses 8527 8534 +7
Continue to review full report at Codecov.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot improve on your choice of tag (doc:
) but it seems weird.
@@ -51,13 +61,15 @@ class RowReader { | |||
// NOLINTNEXTLINE(readability-identifier-naming) | |||
static std::int64_t constexpr NO_ROWS_LIMIT = 0; | |||
|
|||
GOOGLE_CLOUD_CPP_BIGTABLE_ROW_READER_CTOR_DEPRECATED() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this change, the lack of default constructor is annoying. It makes it impossible to write code like this:
RowReader reader;
if (condition) {
reader = table.ReadRows(...);
} else {
reader = table.ReadRows(... /* but slightly different dots */);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #8892
That is probably a sign that I should have split this up into two PRs.
|
The deprecation part of #8854
This change is