feat(storage): new option to disable decompressive transcoding #8834
Conversation
For objects stored in gzip format (and with contentEncoding == "gzip") GCS over HTTP automatically decompresses the object during download. Some applications may want to read the object in compressed format. Support this use-case with a new option (`AcceptEncoding`) for `Client::ReadObject()`, and a new helper function (`AcceptEncodingGzip() `) that returns this option with the correct value.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8834 +/- ##
==========================================
- Coverage 94.50% 94.46% -0.04%
==========================================
Files 1356 1356
Lines 120137 120205 +68
==========================================
+ Hits 113533 113553 +20
- Misses 6604 6652 +48
Continue to review full report at Codecov.
|
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @coryan)
google/cloud/storage/well_known_headers.h line 295 at r2 (raw file):
* compressed with `gzip` and have their `content_encoding()` attribute * set accordingly. At the time of this writing GCS does not decompress * objects stored with other compression algorithms, nor does not it
s/nor does not it/nor does it/
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
For objects stored in gzip format (and with contentEncoding == "gzip")
GCS over HTTP automatically decompresses the object during download.
Some applications may want to read the object in compressed format.
Support this use-case with a new option (
AcceptEncoding) forClient::ReadObject(), and a new helper function(
AcceptEncodingGzip()) that returns this option with the correct value.Fixes #8305
This change is