Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(storage): add custom-dual regions example #8595

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 25, 2022

Motivated by #8586


This change is Reviewable

@snippet-bot
Copy link

snippet-bot bot commented Mar 25, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 25, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: ccc831a41f6f9797deebbc528a933c525aa9b08f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f7e7a3e15340cee61cca847b4833247ee6512a0b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #8595 (8d99104) into main (5308f1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8595   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files        1456     1456           
  Lines      123806   123820   +14     
=======================================
+ Hits       115666   115681   +15     
+ Misses       8140     8139    -1     
Impacted Files Coverage Δ
...e/cloud/storage/examples/storage_bucket_samples.cc 93.84% <100.00%> (+0.22%) ⬆️
google/cloud/pubsub/samples/samples.cc 92.02% <0.00%> (-0.08%) ⬇️
google/cloud/storage/internal/curl_handle.h 82.85% <0.00%> (+2.85%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5308f1c...8d99104. Read the comment docs.

@coryan coryan force-pushed the feat-storage-support-cdr-v2 branch from f7e7a3e to 001e8c8 Compare March 25, 2022 13:31
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 001e8c864181082e7b7b0ce5610b7656a440da20

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review March 25, 2022 13:52
@coryan coryan requested a review from a team as a code owner March 25, 2022 13:52
@coryan coryan added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 25, 2022
@coryan
Copy link
Contributor Author

coryan commented Mar 25, 2022

I want to double check some things before merging.

@coryan coryan force-pushed the feat-storage-support-cdr-v2 branch from 001e8c8 to 8d99104 Compare April 4, 2022 12:50
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8d99104c06fb21a0ff79d2ce4f611a465c01a990

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 4, 2022
@coryan coryan enabled auto-merge (squash) April 4, 2022 13:16
@coryan coryan merged commit 8f2471c into googleapis:main Apr 4, 2022
@coryan coryan deleted the feat-storage-support-cdr-v2 branch April 4, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants