cleanup!: change storage bazel visibility to private by default #8583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of googleapis#3701 The target `//google/cloud/storage:google_cloud_cpp_storage_grpc` became non-public, but it was experimental so it didn't need to be deprecated. All `cc_test` targets became private. The `//google/cloud/storage:storage_client_testing` target remains public.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8583 +/- ##
==========================================
- Coverage 93.90% 93.90% -0.01%
==========================================
Files 1462 1462
Lines 126954 126954
==========================================
- Hits 119217 119211 -6
- Misses 7737 7743 +6
Continue to review full report at Codecov.
|
coryan
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3701
The target
//google/cloud/storage:google_cloud_cpp_storage_grpcbecamenon-public, but it was experimental so it didn't need to be
deprecated.
All
cc_testtargets became private.The
//google/cloud/storage:storage_client_testingtarget remainspublic.
This change is