Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup!: change bazel visibility to private for {tests,quickstarts,examples,samples,benchmarks} #8578

Merged
merged 5 commits into from
Mar 22, 2022

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Mar 22, 2022

Part of #3701

These changes are only affecting whole BUILD files that are in a directory that is obviously not intended to be part of a user-facing API. These are (integration) tests, examples, samples, benchmarks, and quickstarts.


This change is Reviewable

@devjgm devjgm requested a review from a team as a code owner March 22, 2022 18:23
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 22, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b83ff7f6b275b5078a729aa937706498da2ec04e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #8578 (b83ff7f) into main (8195b41) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8578      +/-   ##
==========================================
- Coverage   93.94%   93.94%   -0.01%     
==========================================
  Files        1462     1462              
  Lines      126883   126883              
==========================================
- Hits       119203   119202       -1     
- Misses       7680     7681       +1     
Impacted Files Coverage Δ
...cloud/pubsub/internal/subscription_session_test.cc 97.75% <0.00%> (-0.50%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8195b41...b83ff7f. Read the comment docs.

@devjgm devjgm merged commit 047dfe6 into googleapis:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants