feat(common): g::c::future support for coroutines
#8532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate `google::cloud::future<T>` with C++20 coroutines. This feature is optional, and only enabled if the compiler supports C++20. Because some C++20 compilers disable coroutines by default, this feature is disabled if `__cpp_impl_coroutine` is not defined, or it is 0.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8532 +/- ##
==========================================
- Coverage 93.92% 93.92% -0.01%
==========================================
Files 1453 1453
Lines 125889 125889
==========================================
- Hits 118247 118239 -8
- Misses 7642 7650 +8
Continue to review full report at Codecov.
|
I think the new code is cleaner too, so there is that.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devjgm
approved these changes
Mar 14, 2022
|
|
||
| /// Specialize `std::coroutine_traits` for `google::cloud::future<T>`. | ||
| template <typename T, typename... Args> | ||
| requires(!std::is_void_v<T> && !std::is_reference_v<T>) /**/ |
There was a problem hiding this comment.
yes, clang-format does a poor job with these otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate
google::cloud::future<T>with C++20 coroutines. Thisfeature is optional, and only enabled if the compiler supports C++20.
Because some C++20 compilers disable coroutines by default, this feature
is disabled if
__cpp_impl_coroutineis not defined, or it is 0.I verified our C++20 build actually tests these features.
This change is